Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Survey Responses to Public Dashboard #124
Adding Survey Responses to Public Dashboard #124
Changes from 72 commits
758d2d8
a526257
c4cfdfa
427f44b
94f48c5
7f3d477
74768f7
99e0cc8
eb14800
3a3533d
f832c83
dc3bab8
ea0c660
157ad15
e6c7fe6
8ac86b7
5fe10e1
7d8a114
8a2c2f4
a04a316
af3dfa8
399c7b3
75d4fb6
45026b7
733e559
8a4869b
df6fde3
d6b2d80
0da6c33
8ff0b8b
8cdd6de
4ea4724
eff012b
4d0f7fb
6c7496f
1e41c35
80263ad
c98b623
10fe708
1b88265
1a7b911
0fae9fc
f1e94f5
61fa0f1
3fd5d01
e46a4b6
0f31ed6
596886a
8d0e285
130b732
fd16cad
52bc509
548a449
7e64d12
feb80dc
2dbd723
b02c1de
5e79051
7dbef2d
39d1156
7c7a718
6c38e97
a57a30f
b207efa
6957500
2e2e269
f9f3ba5
3d4c5fb
40c1478
6a36770
41db5cf
fb7bc70
334c95b
ef4786e
91cc8e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you have removed
load_composite_trips
, you can also removefilter_composite_trips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that
filter_composite_trips
is not identical tofilter_labeled_trips
because it doesn't filter by blank user input. However, I don't understand why you are not filtering by blank user input. It should be possible to just callload_all_participant_trips
instead ofload_all_confirmed_trips
followed byfilter_composite_trips
to achieve the same result.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do, later, but I need all of the trips in order to create the "all trips for which a survey was prompted" information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes to the data loading (including pushing it to scaffolding) in #135 - I have the filtered, unfiltered, and file suffix all returned from a function in scaffolding now - I don't have the debug_df or quality_text included since it varies chart to chart