Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate common base mode colors into public dashboard #148
Integrate common base mode colors into public dashboard #148
Changes from 27 commits
58d7697
ee7cc2e
25259d2
7b456a9
7137a01
6630214
998a725
ff703a9
1808c69
3094859
86f3798
e2cd09c
b07ffd1
2e2bedc
d4cbcc1
26c39a8
8c8b7ff
1ef4c3b
ac65528
fccc53d
a0fae22
12d4795
51eb1da
a5180c4
78d105a
e634d8e
ed0c4c6
75b4ce2
a1620e4
75d594c
f1176f6
399cd5a
60f5af3
0e5d869
b3a0391
0034d6f
669d521
afaed09
9cefa33
ec355ca
821fe7d
ac07f67
3cbd76b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need the values_to_translations here? we should use the display modes in the energy and emission impact plots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need the values_to_translations() here. It's being used only with the Stacked Bar Charts. We are using display modes in the energy and emission impact plots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so we have
mode_confirm
,mode_confirm_w_other
andMode_confirm
all at the same time? When we remove the csvs I think we should probably get rid ofMode_confirm
and just usevalues_to_translations
to prevent confusion.