Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Improvements in User Stats Processing #124
Performance Improvements in User Stats Processing #124
Changes from all commits
a7c7014
e0e2da6
406e3bf
efb9436
3474dbd
c6c5235
ee62b79
51d18ff
8c95c36
dc93c35
cd84641
0e8d15c
8617d6d
26085a1
8c8faa2
c1a30e5
95f2c66
d1715e5
f73cd4d
c6fb3d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this is used. I see that the
patched_data
object is created here, but I don't see it used anywhere else in this PR. I even see that line 129 references thisPatch
object in a comment, but I don't see any of thePatch
object methods, such asappend
.Are we actually using
patch
? If not, what are we doing for lazy loading?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was a relic of a prior iteration I made; I can remove/clean this section in another PR.