Adapt dose engine concept to dev_varRBErobOpt #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First (real) commit into the refactorDoseCalc branch. Includes all up till now created dose calc engines for the refactoring of the dose calculation in MatRad. The goal of this refactoring is, to leave the full script-file based dose calculation (which is used right now) and use a modular class based dose calculation. This should provide a modifiable and modular engine class for each major calculation method. Those engines can then be expanded and specified by inheritance. This solution should also add a factory like overview, over possible engines for a given treatment planning.
Merge new master changes into dev_refactorDoseCalc
matRad_calcDose funktion should supersede the funktion of the other matRad_... calc funktions by creating the fitting engine and call the dose calc method.
Removed the content of deprecated functions and replaced their content with the creation and call of a fitting doseCalcEngine. The functions can still be called exactly like before in order to assure downwards compatibility.
…on or are now implemented inside the engines
Merge e0404/master branch into dev_refactorDoseCalc
# Conflicts: # AUTHORS.txt # MatRad_Config.m # matRad_calcDoseInit.m # matRad_calcPhotonDose.m
# Conflicts: # matRad_calcPhotonDose.m
Forgot to turn off the visualization for the lateral cut off inside the physical dose calculation, which resulted in an octave error
# Conflicts: # matRad_calcParticleDose.m
# Conflicts: # matRad_calcParticleDose.m
# Conflicts: # matRad_calcParticleDose.m
# Conflicts: # matRad_calcParticleDose.m
JenHardt
reviewed
Apr 19, 2024
JenHardt
reviewed
Apr 19, 2024
4D Update to scenario handling with carbon
…doseEnginesRobOpt
Test Results 3 files ±0 3 suites ±0 25m 4s ⏱️ -32s For more details on these failures, see this check. Results for commit 322f94a. ± Comparison against base commit 49c7411. |
…/matRad into refactor/doseEnginesRobOpt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adapts the dose engine concept to the dev_varRBErobOpt branch. Since the dose engine concept is currently residing on the dev branch, this PR prepares the union of dev and dev_varRBErobOpt.
Some adaptations are still to be done (mostly with regards to biological model management and maybe scenario management - now would be the time to change it).
I will assign a few reviewers to do a first rough validation of this refactoring.