Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: dose Accumulation #685

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

JenHardt
Copy link
Contributor

@JenHardt JenHardt commented Dec 6, 2023

x and y direction were switched in the dose accumulation and in the dvf generation, fixed that. Added dvfType and doseeAccumulation Type as varriable

x and y direction were switched in the dose accumulation and in the dvf generation, fixed that. Added dvfType and doseeAccumulation Type as varriable
Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing due to typo

4D/matRad_addMovement.m Outdated Show resolved Hide resolved
Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a problem in example 10 that the dvfType is not chosen correctly:

2023-12-07T07:56:12.1154894Z {�Error using matRad_runTests
2023-12-07T07:56:12.1155517Z Experienced an error during testing of matRad_example10_4DphotonRobust_test.
2023-12-07T07:56:12.1156047Z Error-Message:
2023-12-07T07:56:12.1156316Z Error using matRad_addMovement
2023-12-07T07:56:12.1156655Z Chosse Push or Pull DVF type
2023-12-07T07:56:12.1156864Z
2023-12-07T07:56:12.1157050Z Error in matRad_example10_4DphotonRobust_test (line 125)


matRad_cfg = MatRad_Config.instance();

% book keeping
ct.motionPeriod = motionPeriod;
ct.numOfCtScen = numOfCtScen;

if ~(strcmp(dvfType, 'pull') || strcmp(dvfType,'push'))
matRad_cfg.dispError('Chosse Push or Pull DVF type')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "choose" instead of "chosse"

@wahln
Copy link
Contributor

wahln commented Dec 11, 2023

Would it maybe make sense to change the matRad_addMovement function to use the inputParser to give the optional arguments as Name-Value pairs? What do you think?

Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wahln wahln merged commit edfe9c8 into e0404:dev_varRBErobOpt Dec 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants