-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/topas cordinate system #790
Conversation
The beam direction is now alway along the topas world axis Z, and the patient is rotated accordingly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v3 #790 +/- ##
==========================================
- Coverage 50.28% 50.24% -0.04%
==========================================
Files 598 598
Lines 37258 37262 +4
==========================================
- Hits 18734 18722 -12
- Misses 18524 18540 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very neat fix with minimal changes, thanks. If I understand it correctly, it is done solely by rotating to a different orientation in the TOPAS template file, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please quickly explain to me the logic behind the new rotated system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the idea is that we have to rotated by 90 degrees along the z axis and then along the x axis to get the basic patient rotation, so that at gantry and couch angle 0 the beam is along the patients yaxis. I split the rotations up like this to have the correct order of rotations
One more question, what gantry angle / couch angle combinations did you test it with? |
sure i tested the gantry and couch angle combinations of (0,0), (0,90),(90,0), and (45,45) |
We noticed a asymmetry in the simulated dose by TOPAS if the main beam direction is not the z direction, the interface was changed to have the beam along z with the patient being rotated