Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/topas cordinate system #790

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

JenHardt
Copy link
Contributor

We noticed a asymmetry in the simulated dose by TOPAS if the main beam direction is not the z direction, the interface was changed to have the beam along z with the patient being rotated

The beam direction is now alway along the topas world axis Z, and the patient is rotated accordingly
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (30d5d9b) to head (5713c15).
Report is 1 commits behind head on rc/v3.

Files with missing lines Patch % Lines
...gines/@matRad_DoseEngineBase/getAvailableEngines.m 0.00% 1 Missing ⚠️
...nes/@matRad_DoseEngineBase/matRad_DoseEngineBase.m 50.00% 1 Missing ⚠️
...atRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            rc/v3     #790      +/-   ##
==========================================
- Coverage   50.28%   50.24%   -0.04%     
==========================================
  Files         598      598              
  Lines       37258    37262       +4     
==========================================
- Hits        18734    18722      -12     
- Misses      18524    18540      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very neat fix with minimal changes, thanks. If I understand it correctly, it is done solely by rotating to a different orientation in the TOPAS template file, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please quickly explain to me the logic behind the new rotated system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea is that we have to rotated by 90 degrees along the z axis and then along the x axis to get the basic patient rotation, so that at gantry and couch angle 0 the beam is along the patients yaxis. I split the rotations up like this to have the correct order of rotations

@wahln
Copy link
Contributor

wahln commented Nov 17, 2024

One more question, what gantry angle / couch angle combinations did you test it with?

@JenHardt JenHardt closed this Nov 18, 2024
@JenHardt JenHardt reopened this Nov 18, 2024
@JenHardt
Copy link
Contributor Author

One more question, what gantry angle / couch angle combinations did you test it with?

sure i tested the gantry and couch angle combinations of (0,0), (0,90),(90,0), and (45,45)

@wahln wahln merged commit 4a509ef into e0404:rc/v3 Nov 18, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants