DVH Widget Bugfix #793
Merged
DVH Widget Bugfix #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Wahl <[email protected]>
…d carbon Signed-off-by: Niklas Wahl <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## dev #793 +/- ##
==========================================
+ Coverage 50.27% 51.26% +0.99%
==========================================
Files 598 598
Lines 37262 37272 +10
==========================================
+ Hits 18732 19108 +376
+ Misses 18530 18164 -366 ☔ View full report in Codecov by Sentry. |
|
amitantony
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and testing of the
matRadGUI widgets. The most important changes involve enhancing thematRad_DVHWidgetand itsshowDVHfunction, updating thematRad_showDVHfunction, and adding new test cases for various widgets.Enhancements to
showDVHfunction:matRad/gui/widgets/matRad_DVHWidget.m: Added logic to handle scenarios more robustly by introducing thectvariable and updating the scenario model creation and checks.Updates to
matRad_showDVHfunction:matRad/planAnalysis/matRad_showDVH.m: Modified thexlabelfunction to include theaxesHandleparameter for better plot labeling.Addition of new test cases:
test/gui/test_gui_DVHStatsWidget.m: Added multiple test functions to constructDVHStatsWidgetwith different plan types (Photon, Proton, Carbon, Helium) and verify their correct instantiation.test/gui/test_gui_PlanWidget.m: Added test functions to constructPlanWidgetwith different plan types (TG119, Photon, Proton, Carbon, Helium) and verify their correct instantiation. [1] [2]test/gui/test_gui_exportWidget.m: Added a test function to constructexportWidgetwith a Carbon plan and verify its correct instantiation.test/gui/test_gui_viewingWidget.m: Added test functions to constructViewingWidgetwith different plan types (TG119, Photon, Proton, Carbon, Helium) and verify their correct instantiation. [1] [2]