-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forumtrack new shortcodes #5318
Open
rica-carv
wants to merge
13
commits into
e107inc:master
Choose a base branch
from
rica-carv:rica-carv-forumtrack_new_shortcodes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Forumtrack new shortcodes #5318
rica-carv
wants to merge
13
commits into
e107inc:master
from
rica-carv:rica-carv-forumtrack_new_shortcodes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditional check for external linked avatars. Without the code, external linked avatars not available are shown without the default avatar
Changed file_exists to fopen, to check if remote file exists
Aditional change to make default avatar image render
Add files via upload
…runcate Revert "Add files via upload"
Code Climate has analyzed commit 33518b0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 38.9% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
New shortcodes to display tracked forum topics data on the user tracked forum topics. Probably this track code can be candidate to use normal shortcodes, since the current hardcoded shortcodes inside the code can't be overriden by theme shortcodes. This pull is just a workaround.
Description
Added
LASTPOSTUSERAVATAR
,VIEWS
andREPLIES
shortcodesHow Has This Been Tested?
Tested with e107 v2.3.3
Types of Changes
Checklist