Add timeout to resume request

e2b-dev · Nov 12, 2024 · b0b74ea · b0b74ea
1 parent eaccd6e
commit b0b74ea
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 2 deletions.
diff --git a/packages/js-sdk/src/api/schema.gen.ts b/packages/js-sdk/src/api/schema.gen.ts
diff --git a/packages/js-sdk/src/sandbox/index.ts b/packages/js-sdk/src/sandbox/index.ts
@@ -220,9 +220,9 @@ export class Sandbox extends SandboxApi {
   static async resume<S extends typeof Sandbox>(
     this: S,
     sandboxId: string,
-    opts?: Pick<SandboxOpts, 'requestTimeoutMs'>
+    opts?: Pick<SandboxOpts, 'requestTimeoutMs' | 'timeoutMs'>
   ): Promise<InstanceType<S>> {
-    const id = await Sandbox.resumeSandbox(sandboxId, opts)
+    const id = await Sandbox.resumeSandbox(sandboxId, opts?.timeoutMs ?? this.defaultSandboxTimeoutMs, opts)
 
     return this.connect(id, opts)
   }

diff --git a/packages/js-sdk/src/sandbox/sandboxApi.ts b/packages/js-sdk/src/sandbox/sandboxApi.ts
@@ -187,6 +187,7 @@ export class SandboxApi {
 
   protected static async resumeSandbox(
     sandboxId: string,
+    timeoutMs: number,
     opts?: SandboxApiOpts
   ): Promise<string> {
     const config = new ConnectionConfig(opts)
@@ -198,6 +199,9 @@ export class SandboxApi {
           sandboxID: sandboxId,
         },
       },
+      body: {
+        timeout: this.timeoutToSeconds(timeoutMs),
+      },
     })
 
     if (res.error?.code === 404) {

diff --git a/spec/openapi.yml b/spec/openapi.yml
@@ -216,6 +216,15 @@ components:
         envVars:
           $ref: "#/components/schemas/EnvVars"
 
+    ResumedSandbox:
+      properties:
+        timeout:
+          type: integer
+          format: int32
+          minimum: 0
+          default: 15
+          description: Time to live for the sandbox in seconds.
+
     Template:
       required:
         - templateID
@@ -471,6 +480,12 @@ paths:
         - ApiKeyAuth: []
       parameters:
         - $ref: "#/components/parameters/sandboxID"
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/ResumedSandbox"
       responses:
         "201":
           description: The sandbox was resumed successfully