Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SDK refs #475

Merged
merged 64 commits into from
Nov 29, 2024
Merged

Improve SDK refs #475

merged 64 commits into from
Nov 29, 2024

Conversation

0div
Copy link
Contributor

@0div 0div commented Nov 22, 2024

Description

  • Version dropdown in TOC
  • Improve js-sdk api ref with typedoc markdown options
  • Levarage auto anchor link generation with h2 and h3s for cli sdk
  • CSS styling

@0div 0div added the docs Improvements or additions to documentation label Nov 22, 2024
@0div 0div self-assigned this Nov 22, 2024
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 8dbfe63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0div 0div requested review from mlejva and removed request for mishushakov and jakubno November 22, 2024 01:36
@mishushakov
Copy link
Member

I just took a quick look at the Vercel preview of curiosity:

  • Don't see a dropdown anywhere?
  • For JS, can you remove "Defined in", it isn't particularly useful?
  • Can you make methods either bold or ### (h3) in markdown?
  • Parameters look different in javascript docs (table) and python (list)

@mlejva
Copy link
Member

mlejva commented Nov 22, 2024

I just took a quick look at the Vercel preview of curiosity:

  • Don't see a dropdown anywhere?
  • For JS, can you remove "Defined in", it isn't particularly useful?
  • Can you make methods either bold or ### (h3) in markdown?
  • Parameters look different in javascript docs (table) and python (list)

We discussed it in person and made some compromises mostly around unifying styling and information. The problem is we would need to write our own docstrings parser as the current ones are sufficient for us.

  • Don't see a dropdown anywhere?

Version dropdown? We haven't figured out where to put it yet.
EDIT: We have a good idea now.

  • Can you make methods either bold or ### (h3) in markdown?

This one is the main thing we need to figure out if we can do.

  • Parameters look different in javascript docs (table) and python (list)

Here we compromised and it will be different

@0div 0div requested a review from ValentaTomas as a code owner November 22, 2024 18:05
@mishushakov
Copy link
Member

mishushakov commented Nov 22, 2024

Will you also be adding Pty and Commands types to JS ref?

@0div
Copy link
Contributor Author

0div commented Nov 22, 2024

Will you also be adding Pty and Commands types to JS ref?

good catch @mishushakov , I have included them by fixing the typedoc config

@mlejva
Copy link
Member

mlejva commented Nov 28, 2024

Todo list before we can merge release (I'm working on both)

  • move the top bar navigation "Documentation", "SDK Reference", "Dashboard" to the navbar
  • Fix the navbar item selection not staying selected when you open a page

…ng the navigation items not being highlighted in the sdk reference
@0div 0div merged commit bc17caa into main Nov 29, 2024
3 checks passed
@0div 0div deleted the improved-api-refs branch November 29, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants