Add recursive directory watch #488
Conversation
|
There was a problem hiding this comment.
Overall this looks good from a code perspective 👍
From a product perspective, do you think it would be better not to make recursive an option and just always watch recursively ? Also taking into account that the instructions said:
Make as few changes to the communication between envd and SDKs as possible
ValentaTomas
added
feature
- Removed code runtime version check to prevent issues until further investigation
dobrac
force-pushed
the
watch-dir-recursive
branch
from
666b3d4 to
724e857
Compare
packages/js-sdk/src/sandbox/index.ts
Outdated
| apiUrl: this.envdApiUrl, | ||
| logger: opts?.logger, | ||
| }, | ||
| opts?.envdVersion |
There was a problem hiding this comment.
why not like this?
| apiUrl: this.envdApiUrl, | |
| logger: opts?.logger, | |
| }, | |
| opts?.envdVersion | |
| apiUrl: this.envdApiUrl, | |
| logger: opts?.logger, | |
| envdVersion: opts?.envdVersion | |
| }, |
There was a problem hiding this comment.
I was thinking it may be different scope than "ConnectionConfig" (maybe in the future part of some Metadata interface?), but If you want, I can move it there
There was a problem hiding this comment.
Resolved by wrapping envdVersion to the metadata object
| const newContent = 'This file has been modified.' | ||
|
|
||
| await sandbox.files.makeDir(`${dirname}/${nestedDirname}`) | ||
| onTestFinished(() => sandbox.files.remove(dirname)) |
There was a problem hiding this comment.
Technically correct, but not really necessary, the sandbox is killed after the test ends. This will only add one call to sandbox, but you could do this for local testing. Locally the same sandbox is reused
| onTestFinished(() => sandbox.files.remove(dirname)) | |
| if (isDebug) { | |
| onTestFinished(() => sandbox.files.remove(dirname)) | |
| } |
| const content = 'This file will be watched.' | ||
|
|
||
| await sandbox.files.makeDir(dirname) | ||
| onTestFinished(() => sandbox.files.remove(dirname)) |
Adds recursive directory watch to the SDK and documentation section. Requires merging and deploying e2b-dev/infra#210 first.
Proposed API change:
JS
Python
Notes
Python SDK was generated using buf.build/protocolbuffers/python:v28.3. The runtime check was removed for now. Further tests might be required to make sure the runtime is at least the generated version before including the runtime check.
Changing the following in the file spec/envd/buf-python.gen.yaml (generator) allows using different protoc-gen-python version:
From:
plugin: pythonTo:
plugin: buf.build/protocolbuffers/python:v28.3