Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect the root URL route to new Webflow hosting #493

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

mlejva
Copy link
Member

@mlejva mlejva commented Dec 6, 2024

This PR changes the target hostname for the root route (/) for https://e2b.dev to reflect our new landing page hosting.

This is the first step towards removing the reverse proxy handling from our public web app.

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 10a7bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but can we remove "made in Webflow"

@mlejva
Copy link
Member Author

mlejva commented Dec 6, 2024

looks good, but can we remove "made in Webflow"

It shouldn't be there. Try reloading without cache pls

@mishushakov
Copy link
Member

another thing is: default is light mode, but my os in dark mode

@mishushakov
Copy link
Member

opened in incognito
Screenshot 2024-12-06 at 01 52 30

Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlejva
Copy link
Member Author

mlejva commented Dec 6, 2024

opened in incognito Screenshot 2024-12-06 at 01 52 30

This is really weird because if you go to https://e2b-dev.webflow.io/ which this deployed route points to, it's not there

@mlejva mlejva merged commit b416c63 into main Dec 6, 2024
2 checks passed
@mlejva mlejva deleted the new-landing-page-hosting branch December 6, 2024 02:07
@mlejva
Copy link
Member Author

mlejva commented Dec 6, 2024

I had to revert this merge because the fix for removing webflow badge didn't work

mlejva added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants