Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use billing subdomain to simplify dashboard for custom domains #514

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

jakubno
Copy link
Member

@jakubno jakubno commented Dec 19, 2024

Description

Billing service runs on billing. subdomain, so you can pass only 1 url now

@jakubno jakubno requested a review from mishushakov as a code owner December 19, 2024 13:04
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: b72817d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think domain sounds confusing, maybe use apiHost? or something that should tell it is hostname/url/address for the API

@jakubno
Copy link
Member Author

jakubno commented Dec 19, 2024

It isn't api url, it's the base url:
domain: e2b.dev
api url: https://api.e2b.dev

@mlejva mlejva merged commit 211362c into main Dec 19, 2024
2 checks passed
@mlejva mlejva deleted the simplify-custom-domain branch December 19, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants