Add result code to response messages #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Jun 18, 2024
| @@ -735,8 +738,9 @@ class rpc_session | |||
| try { | |||
| ptr<buffer> resp_ctx = resp->get_ctx(); | |||
| int32 resp_ctx_size = (resp_ctx) ? resp_ctx->size() : 0; | |||
| int32 result_code_size = sizeof(int32_t); | |||
There was a problem hiding this comment.
Instead of this, can you please use
int32 result_code_size = sizeof(cmd_result_code);There was a problem hiding this comment.
ok
my concern was that we will use the put_i32 and get_i32 functions, so it result_code_size is not sizeof(int32_t), weird things may happen
There was a problem hiding this comment.
Yeah, good point, that makes more sense. Let me make a change to use sizeof(int32_t) and instead put int32_t to cmd_result_code definition.
amichon-kalray
force-pushed
the
dev/amichon/master
branch
2 times, most recently
from
18e0dc3
to
e49c962
Compare
In some cases, the response is marked as accepted even if there was an error. Therefore, including the accepted tag in the response message is not enough: a follower may believe that an auto forwarded request was successful when it wasn't. Signed-off-by: Alex Michon <[email protected]>
amichon-kalray
force-pushed
the
dev/amichon/master
branch
from
e49c962
to
3b2d3b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the response is marked as accepted even if there was an error. Therefore, including the accepted tag in the response message is not enough: a follower may believe that an auto forwarded request was successful when it wasn't.
Resolves #513