Add timeout to async_connect operation #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the network goes down during a async_connect, we may end up being stuck forever in this function since there is no timeout to cancel it. Signed-off-by: Alex Michon <[email protected]>
greensky00
previously approved these changes
Jun 18, 2024
greensky00
approved these changes
Jun 18, 2024
szmyd
added a commit
to eBay/nuraft_mesg
that referenced
this pull request
Jul 29, 2024
Fixes include eBay/NuRaft#516
szmyd
added a commit
to eBay/nuraft_mesg
that referenced
this pull request
Jul 29, 2024
* Update NuRaft to latest. Fixes include eBay/NuRaft#516 * Add missing case statements for error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the network goes down during a async_connect, we may end up being stuck forever in this function since there is no timeout to cancel it.