Add flying_bytes for throttling. #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZZhongge
commented
Oct 15, 2024
ZZhongge
commented
- Add track for flying bytes
- Add a new throttling flying bytes
2. Add a new throttling flying bytes
greensky00
reviewed
Oct 15, 2024
include/libnuraft/peer.hxx
Outdated
| /** | ||
| * Current flying bytes of append entry requests. | ||
| */ | ||
| std::atomic<size_t> flying_bytes; |
There was a problem hiding this comment.
bytes_in_flight_ sounds better. Rename related functions and logs too.
include/libnuraft/peer.hxx
Outdated
| @@ -329,6 +346,7 @@ private: | |||
| ptr<req_msg>& req, | |||
| ptr<rpc_result>& pending_result, | |||
| bool streaming, | |||
| size_t total_size, | |||
There was a problem hiding this comment.
The name is ambiguous (total size of what?). I'd rather renaming it req_size_bytes.
include/libnuraft/raft_params.hxx
Outdated
| /** | ||
| * Max flying bytes we allow. If it is zero, we don't use it as throttling. | ||
| */ | ||
| ulong max_flying_bytes_; |
There was a problem hiding this comment.
This parameter will be used for streaming mode only right? then max_bytes_in_flight_in_stream_.
src/handle_append_entries.cxx
Outdated
Comment on lines
310
to
312
| (last_streamed_log_idx + 1) || | ||
| ( params->max_flying_bytes_ && | ||
| p->get_flying_bytes() > params->max_flying_bytes_)) { |
There was a problem hiding this comment.
Indent
if (max_gap_in_stream + p->get_next_log_idx() <=
(last_streamed_log_idx + 1) ||
(params->max_flying_bytes_ &&
p->get_flying_bytes() > params->max_flying_bytes_)) {
include/libnuraft/peer.hxx
Outdated
| } | ||
|
|
||
| void flying_bytes_sub(size_t total_size) { | ||
| flying_bytes.fetch_sub(total_size); |
There was a problem hiding this comment.
Can you add the below
assert(flying_bytes >= 0);right after this line? so as to catch any bug that corrupts this number during the test.
greensky00
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.