Merge streaming branch into master #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* asio_service support stream mode 1. set TCP_NODELAY = true this can be set after the socket open. So we can't set it in constructor. (async_connect will open the socket) 2. does the order of calling all the when_done matter when error occur? in write path when_done(error triggered) -> close_socket(in destructor) in read path close_socket(directly call) -> when_done(error triggered) 3. keep the old path for all request if stream_mode_ = false already addressed all the comment. * handle comments * fix error * error handle * move all function call out of lock * [Refactoring] renaming, comments, indent --------- Co-authored-by: lihzeng <[email protected]> Co-authored-by: Jung-Sang Ahn <[email protected]>
* Enhance test for stream asio 1. client send requests to wrong endpoint 2. client is closed after sending requests 3. server timeout after sending requests 4. server is closed after sending requests * test enhance * test fix --------- Co-authored-by: lihzeng <[email protected]>
* Implement stream mode in peer and raft server(a proposal) add an additional flag: flying_append_entry_request. it is used to present if it is the first request. if streaming is disable, we can only send the new request when flying request = 0 * minor fix * address comments * refractor * refractory * refine --------- Co-authored-by: lihzeng <[email protected]>
* Add stream functional test and fix bugs 1. add four test for stream function 2. fix throttling, lock, runtime change, and enable stream * handle comment * Need disable stream when become the leader --------- Co-authored-by: lihzeng <[email protected]>
* minor fix * process response from stale connection * minor fix --------- Co-authored-by: lihzeng <[email protected]>
* 1. Add track for flying bytes 2. Add a new throttling flying bytes * minor fix * handle comments * [Update PR] Format, comment, whitespace --------- Co-authored-by: lihzeng <[email protected]> Co-authored-by: Jung-Sang Ahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.