Merge pull request #30 from eBay/make-test-golden-not-async

Make test golden not async
eBay · Feb 28, 2020 · 91841e1 · 91841e1
2 parents d5b441a + 0b8eca1
commit 91841e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/golden_toolkit/CHANGELOG.md b/packages/golden_toolkit/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.2.3
+
+Removed Future return type from `testGoldens`.
+
 ## 0.2.2
 
 Added `deviceSetup` to multiscreenGolden to allow pumping customization when device configuration (ex: screen size) changes

diff --git a/packages/golden_toolkit/lib/src/testing_tools.dart b/packages/golden_toolkit/lib/src/testing_tools.dart
@@ -109,11 +109,11 @@ bool _inGoldenTest = false;
 /// [test] test body
 ///
 @isTestGroup
-Future<void> testGoldens(
+void testGoldens(
   String description,
   Future<void> Function(WidgetTester) test, {
   bool skip = false,
-}) async {
+}) {
   group(description, () {
     testWidgets('Golden', (tester) async {
       _inGoldenTest = true;