Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Role: Lawyer #199

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

New Role: Lawyer #199

wants to merge 13 commits into from

Conversation

taelspinner
Copy link

I've been playtesting this role for over two months now, so I'm pretty confident I've worked out most of the bugs. The Lawyer is essentially a reverse-Executioner, who instead of being assigned a target to get exiled, is assigned a target to stop from being exiled. If they fail and their target is exiled, they are killed with them. If their target is killed, like the Executioner, they turn into a different role.

The Lawyer can also, optionally, talk to their client, much like with Lovers-- but I've found that this makes them a little too powerful, since they show up much more often than Lovers. So there is a setting to turn it on or off. Getting killed by your client as an impostor Lawyer is just part of the experience!

I'm aware there are other mods out there that implement a Lawyer role but I conceived of and programmed this version without being aware of them or referencing the code for them.

var writer = AmongUsClient.Instance.StartRpcImmediately(PlayerControl.LocalPlayer.NetId,
(byte)CustomRPC.LawyerToJester, SendOption.Reliable, -1);
writer.Write(lwyr.Player.PlayerId);
AmongUsClient.Instance.FinishRpcImmediately(writer);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget utils.Rpc here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied the Executioner code

@whichtwix
Copy link

whichtwix commented Nov 16, 2023

would lovers be able to see the lawyer chats or vice versa?

@taelspinner
Copy link
Author

would lovers be able to see the lawyer chats or vice versa?

Nope, although if a Lawyer has a Lover their messages are sent to both

@AlchlcDvl
Copy link

would lovers be able to see the lawyer chats or vice versa?

Nope, although if a Lawyer has a Lover their messages are sent to both

seems a bit counter intuitive ngl, things you want only one party to hear would be heard by another. as a loving lawyer, you don't really want your client to know you have a lover

@taelspinner
Copy link
Author

would lovers be able to see the lawyer chats or vice versa?

Nope, although if a Lawyer has a Lover their messages are sent to both

seems a bit counter intuitive ngl, things you want only one party to hear would be heard by another. as a loving lawyer, you don't really want your client to know you have a lover

It's the only way it can really work since there's only one chat window. However you can always word things to send to both parties.

@whichtwix
Copy link

something I saw discussed in reactor a while ago, you can send a rpc specifically to 1 person / certain ppl
https://discord.com/channels/766765155136307250/785869972810367066/1160124744528576522

@taelspinner
Copy link
Author

While that may be, there's still no chat UI for sending stuff to a specific person, and modifying the chat window just for this intersection of the role and a modifier lacks sufficient return on investment for me. Maybe the chat window should be reworked entirely for the mod? I remember one mod, maybe Stellar Roles, had some kind of texting interface in lieu of it. That could add broad support for private messages.

@AlchlcDvl
Copy link

might have to make it something similar to chat command? we can just override the SendChat function and plugin in the targetted rpc to send the message to a specific target

or yeah we could go the stellar approach

@whichtwix
Copy link

While that may be, there's still no chat UI for sending stuff to a specific person, and modifying the chat window just for this intersection of the role and a modifier lacks sufficient return on investment for me. Maybe the chat window should be reworked entirely for the mod? I remember one mod, maybe Stellar Roles, had some kind of texting interface in lieu of it. That could add broad support for private messages.

well like if you send the chat rpc to person x, then person y would never see the message

@taelspinner
Copy link
Author

well like if you send the chat rpc to person x, then person y would never see the message

Yes. The issue with that is there is no UI in place to specify which person you're sending it to. The network code to exclude other players from seeing it is trivial in comparison.

@AlchlcDvl
Copy link

time for someone to make a /whisper chat command

@taelspinner
Copy link
Author

Updated for v5.0.3

@taelspinner
Copy link
Author

Updated for v5.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants