-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNITY-8613 oder units #1323
UNITY-8613 oder units #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhoehn Sorry in advance 😅 Please take a look at my comments and suggestions.
_raml/apps/products/examples/patch_product_productid_request.json
Outdated
Show resolved
Hide resolved
_raml/apps/products/examples/put_product_productid_crossselling_response.json
Outdated
Show resolved
Hide resolved
_raml/apps/products/examples/put_product_productid_crossselling_response.json
Outdated
Show resolved
Hide resolved
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
…g_response.json Co-authored-by: dkluever22 <[email protected]>
…g_response.json Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
…g_response.json Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
…onse.json Co-authored-by: dkluever22 <[email protected]>
…ing_response.json Co-authored-by: dkluever22 <[email protected]>
…ing_response.json Co-authored-by: dkluever22 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have another look at my suggestions. Furthermore, I think that we need to adjust the files /get_product_productid_response.json, /patch_product_productid_response.json and /post_product_response.json as well.
_raml/apps/products/examples/get_product_productid_crossselling_response.json
Outdated
Show resolved
Hide resolved
…g_response.json Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhoehn While reviewing another PR I have noticed a few errors in the orderUnit
description.
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhoehn I have adjusted the description of priceQuantity
a little. Could you take one last look, please?
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
No description provided.