Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNITY-8613 oder units #1323

Merged
merged 36 commits into from
Mar 21, 2024
Merged

Conversation

mhoehn
Copy link
Contributor

@mhoehn mhoehn commented Sep 28, 2023

No description provided.

Copy link
Contributor

@dkluever22 dkluever22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhoehn Sorry in advance 😅 Please take a look at my comments and suggestions.

mhoehn and others added 22 commits October 26, 2023 07:46
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Co-authored-by: dkluever22 <[email protected]>
Copy link
Contributor

@dkluever22 dkluever22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have another look at my suggestions. Furthermore, I think that we need to adjust the files /get_product_productid_response.json, /patch_product_productid_response.json and /post_product_response.json as well.

Copy link
Contributor

@dkluever22 dkluever22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhoehn While reviewing another PR I have noticed a few errors in the orderUnit description.

mhoehn and others added 2 commits December 14, 2023 10:31
Copy link
Contributor

@dkluever22 dkluever22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhoehn I have adjusted the description of priceQuantity a little. Could you take one last look, please?

@dkluever22 dkluever22 merged commit f740239 into ePages-de:master Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants