Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20653] Increase sleep to miss the deadline in macOS flaky tests #4636

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[20653] Increase sleep to miss the deadline in macOS flaky tests #4636

merged 3 commits into from
Apr 10, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Mar 27, 2024 •
edited
Loading

Description

This PR increases the sleep between samples sent to miss the deadline in ownership flaky tests " exclusive_kind_non_keyed_reliable_deadline"

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Refs #20653: Increase sleep to miss the deadline in test exclusive_ki…
7fea8ef 
…nd_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>
@elianalf elianalf added this to the v2.14.1 milestone Apr 2, 2024
@elianalf elianalf marked this pull request as ready for review April 2, 2024 05:59
@elianalf elianalf requested a review from richiprosima April 2, 2024 06:04
@github-actions github-actions bot added ci-pending PR which CI is running labels Apr 2, 2024
@elianalf elianalf requested review from richiprosima and removed request for richiprosima April 2, 2024 12:13
@elianalf
Copy link
Contributor Author

elianalf commented Apr 2, 2024

@richiprosima please test this

@EduPonz EduPonz added the to-do label Apr 3, 2024
@elianalf elianalf force-pushed the hotfix/ownership_test_fail branch from b185210 to e367324 Compare April 3, 2024 06:44
@elianalf elianalf force-pushed the hotfix/ownership_test_fail branch from e367324 to fc4cfa8 Compare April 3, 2024 09:44
@elianalf elianalf requested review from richiprosima and removed request for richiprosima April 3, 2024 15:10
@elianalf
Copy link
Contributor Author

elianalf commented Apr 8, 2024

MAC CI passed once here

@elianalf elianalf requested review from richiprosima and removed request for richiprosima April 8, 2024 05:35
@elianalf
Copy link
Contributor Author

elianalf commented Apr 8, 2024

@richiprosima please test this

@JesusPoderoso JesusPoderoso changed the title [20653] Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline [20653] Increase sleep to miss the deadline in macOS flaky tests Apr 8, 2024
JesusPoderoso
JesusPoderoso approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Jenkins green CI

@elianalf
Copy link
Contributor Author

elianalf commented Apr 9, 2024

@richiprosima please test mac

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 10, 2024
@EduPonz
Copy link

EduPonz commented Apr 10, 2024

@Mergifyio backport 2.13.x 2.10.x

@EduPonz EduPonz merged commit 421bdb2 into master Apr 10, 2024
13 of 17 checks passed
@EduPonz EduPonz deleted the hotfix/ownership_test_fail branch April 10, 2024 05:28
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024 •
edited
Loading

backport 2.13.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 10, 2024
@elianalf @mergify
Increase sleep to miss the deadline in macOS flaky tests (#4636)
3cb0388 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
@mergify mergify bot mentioned this pull request Apr 10, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request Apr 10, 2024
@elianalf @mergify
Increase sleep to miss the deadline in macOS flaky tests (#4636)
0b76ce1 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
@mergify mergify bot mentioned this pull request Apr 10, 2024
Merged
10 tasks
MiguelCompany pushed a commit that referenced this pull request Apr 17, 2024
@elianalf @MiguelCompany
Increase sleep to miss the deadline in macOS flaky tests (#4636)
a2d0c07 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
EduPonz pushed a commit that referenced this pull request Apr 18, 2024
@mergify @elianalf
Increase sleep to miss the deadline in macOS flaky tests (#4636) (#4679)
122dbf8 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)

Co-authored-by: elianalf <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Apr 23, 2024
@elianalf @MiguelCompany
Increase sleep to miss the deadline in macOS flaky tests (#4636)
739e7d5 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
MiguelCompany pushed a commit that referenced this pull request May 20, 2024
@elianalf @MiguelCompany
Increase sleep to miss the deadline in macOS flaky tests (#4636)
cc19ea4 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
MiguelCompany pushed a commit that referenced this pull request May 21, 2024
@elianalf @MiguelCompany
Increase sleep to miss the deadline in macOS flaky tests (#4636)
5f6afe6 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
MiguelCompany pushed a commit that referenced this pull request May 21, 2024
@mergify @elianalf
Increase sleep to miss the deadline in macOS flaky tests (#4636) (#4680)
aa611bd 
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)

Co-authored-by: elianalf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @JesusPoderoso