Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5340: -Werror=template-id-cdtor in C++20 #5341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kistlin
Copy link

@kistlin kistlin commented Oct 17, 2024

Description

solves error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Fixes #5340

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
@JesusPoderoso
Copy link
Contributor

Hi @kistlin, thanks for your contribution!

@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Oct 31, 2024
@JesusPoderoso JesusPoderoso self-requested a review October 31, 2024 08:26
@JesusPoderoso JesusPoderoso added this to the v3.2.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error because of -Werror=template-id-cdtor in C++20
2 participants