Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21886] Feature: Windows ci example testing #5397

Merged
merged 8 commits into from
Nov 27, 2024
Merged

[21886] Feature: Windows ci example testing #5397

merged 8 commits into from
Nov 27, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 12, 2024 •
edited
Loading

Description

This PR introduces example testing in windows (for the moment, just the hello_world_example) by

  • Refactoring the current ci example testing so that the docker composes can be used for Linux and Windows.
  • Creating a new cmake target in which the windows testing image is created with the provided Dockerfile
  • It also adds a new cli argument to the hello_world example matched so the publisher does not start publishing until it has discovered a minimum of participants.

Follow up work

  • Include the rest of the examples in the testing.
  • Maybe separate the windows ci in two jobs: one for building the core library and the other one for testing

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Nov 12, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 12, 2024 14:43
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 12, 2024
@Mario-DL Mario-DL changed the title [21886] Feature: Windows ci hello world example testing and refactor [21886] Feature: Windows ci example testing Nov 12, 2024
@Mario-DL Mario-DL added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Nov 13, 2024
@Mario-DL Mario-DL mentioned this pull request Nov 13, 2024
Closed
16 tasks
@Mario-DL
Refs #21886: Bump windows ci image to 2022
a4b9511 
Signed-off-by: Mario-DL <[email protected]>
@Mario-DL
Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests
0e7ec14 
Signed-off-by: Mario-DL <[email protected]>
@Mario-DL
Refs #21886: Add matched argument to hello_world example
e3d34d1 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Refs #21886: Add Windows testing Dockerfile
98bb37e 
Signed-off-by: Mario-DL <[email protected]>
@Mario-DL
Refs #21886: Refactor CMakeLists example tests and hello_world compose
c300c3e 
Signed-off-by: Mario-DL <[email protected]>
@Mario-DL
Refs #21886: test_hello_world.py fix
53903f0 
Signed-off-by: Mario-DL <[email protected]>
@Mario-DL
Refs #21886: Update docker compose file structure of the rest of exam…
7205a26 
…ples

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from rsanchez15 and removed request for rsanchez15 November 26, 2024 12:01
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 26, 2024
rsanchez15
rsanchez15 previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL
Refs #21886: versions.md
880df48 
Signed-off-by: Mario Dominguez <[email protected]>
@rsanchez15 rsanchez15 merged commit 9c9078f into master Nov 27, 2024
3 checks passed
@rsanchez15 rsanchez15 deleted the feature/21886/hello_world branch November 27, 2024 07:27
@Mario-DL
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 27, 2024
@Mario-DL @mergify
Run examples in Windows CI (#5397)
e30e95d 
* Refs #21886: Bump windows ci image to 2022

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Add matched argument to hello_world example

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21886: Add Windows testing Dockerfile

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Refactor CMakeLists example tests and hello_world compose

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: test_hello_world.py fix

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Update docker compose file structure of the rest of examples

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21886: versions.md

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 9c9078f)

# Conflicts:
#	.github/workflows/reusable-windows-ci.yml
#	versions.md
@mergify mergify bot mentioned this pull request Nov 27, 2024
Open
12 tasks
mergify bot pushed a commit that referenced this pull request Nov 27, 2024
@Mario-DL @mergify
Run examples in Windows CI (#5397)
b41e49a 
* Refs #21886: Bump windows ci image to 2022

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Add matched argument to hello_world example

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21886: Add Windows testing Dockerfile

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Refactor CMakeLists example tests and hello_world compose

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: test_hello_world.py fix

Signed-off-by: Mario-DL <[email protected]>

* Refs #21886: Update docker compose file structure of the rest of examples

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21886: versions.md

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 9c9078f)

# Conflicts:
#	.github/workflows/reusable-windows-ci.yml
#	versions.md
@mergify mergify bot mentioned this pull request Nov 27, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 left review comments

Assignees
No one assigned
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @rsanchez15