-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22280] New property to select preferred key agreement algorithm #5413
base: master
Are you sure you want to change the base?
Conversation
4dba6a6
to
f1458ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting additions. Apart from the comments below, I think it would be interesting to have the possibility of specifying this property in the XML
. If the suggestion is accepted, proper XMLParser
test should be added.
Also, we would need to pair this PR with the corresponding one in docs
Properties are already parsed from the XML. There is no distinction or special processing for the security ones. |
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
c01c29d
to
f941185
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Miguel Company <[email protected]>
5649e24
to
b86e68d
Compare
Signed-off-by: Miguel Company <[email protected]>
b86e68d
to
4164a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Description
DDS security specifies the possibility of selecting the key agreement algorithm used to generate the shared secret at the end of the authentication phase.
The Fast DDS documentation indicates that
Elliptic Curve Diffie-Hellman (ECDH)
is used, but this is only the case if a participant from other vendor starts the authentication and proposes that method.This pull request:
dds.sec.auth.builtin.PKI-DH.preferred_key_agreement
property that allows choosing the preferred algorithm to use.Contributor Checklist
versions.md
file (if applicable).preferred_key_agreement
property Fast-DDS-docs#963Reviewer Checklist