Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22624] System Log error: infinite loop when setting thread affinity fails #5611

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

juanjo4936
Copy link
Contributor

@juanjo4936 juanjo4936 commented Jan 30, 2025

When EPROSIMA_LOG_ERROR fails to configure the current thread affinity or scheduler for itself, it causes a new call to EPROSIMA_LOG_ERROR which experiences the same issue, leading to a recursive loop call of the function. To solve this issue, a new function was added, making it so the errors from the log are written as std::cerr instead of calling EPROSIMA_LOG_ERROR.

@Mergifyio backport 3.1.x 3.0.x 2.14.x

Fixes #5524

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Sorry, something went wrong.

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 added the ci-pending PR which CI is running label Jan 30, 2025
@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Jan 30, 2025
@juanjo4936 juanjo4936 changed the title Refs #22624: Regression test [22624] System Log error: infinite loop when setting thread affinity fails Jan 30, 2025
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 marked this pull request as ready for review January 30, 2025 13:35
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 30, 2025 13:40
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 31, 2025 10:05
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@EugenioCollado EugenioCollado self-requested a review February 5, 2025 10:28
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Copy link
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima February 5, 2025 12:02
@juanjo4936 juanjo4936 merged commit 8097762 into master Feb 6, 2025
17 checks passed
@juanjo4936 juanjo4936 deleted the fix/loop_log_error branch February 6, 2025 07:33
@juanjo4936
Copy link
Contributor Author

https://github.com/Mergifyio backport 3.1.x 3.0.x 2.14.x

Copy link
Contributor

mergify bot commented Feb 6, 2025

mergify bot pushed a commit that referenced this pull request Feb 6, 2025
…5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)
mergify bot pushed a commit that referenced this pull request Feb 6, 2025
…5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)
mergify bot pushed a commit that referenced this pull request Feb 6, 2025
…5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
…Prosima#5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: RookieCLY <2238379153@qq.com>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
…Prosima#5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: RookieCLY <2238379153@qq.com>
MiguelCompany pushed a commit that referenced this pull request Feb 7, 2025
…5611) (#5628)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Javgilavi pushed a commit that referenced this pull request Feb 10, 2025
…5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)
Javgilavi pushed a commit that referenced this pull request Feb 11, 2025
…5611) (#5629)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
EugenioCollado pushed a commit that referenced this pull request Feb 11, 2025
…5611) (#5630)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 8097762)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread_policy_set not supported for M series chips
2 participants