-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22624] System Log error: infinite loop when setting thread affinity fails #5611
Merged
+66
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
EugenioCollado
requested changes
Feb 5, 2025
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
EugenioCollado
requested changes
Feb 5, 2025
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
EugenioCollado
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/Mergifyio backport 3.1.x 3.0.x 2.14.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762)
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762)
Merged
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762)
RookieCLY
pushed a commit
to RookieCLY/Fast-DDS
that referenced
this pull request
Feb 6, 2025
…Prosima#5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> Signed-off-by: RookieCLY <2238379153@qq.com>
RookieCLY
pushed a commit
to RookieCLY/Fast-DDS
that referenced
this pull request
Feb 6, 2025
…Prosima#5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> Signed-off-by: RookieCLY <2238379153@qq.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 7, 2025
…5611) (#5628) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Javgilavi
pushed a commit
that referenced
this pull request
Feb 10, 2025
…5611) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762)
Javgilavi
pushed a commit
that referenced
this pull request
Feb 11, 2025
…5611) (#5629) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
EugenioCollado
pushed a commit
that referenced
this pull request
Feb 11, 2025
…5611) (#5630) * Refs #22624: Regression test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Corrected bug Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: improved structure of the test Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: added reviewer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed reference to new file Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: Added reviwer suggestions Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: modified guard Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #22624: fixed typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 8097762) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When EPROSIMA_LOG_ERROR fails to configure the current thread affinity or scheduler for itself, it causes a new call to EPROSIMA_LOG_ERROR which experiences the same issue, leading to a recursive loop call of the function. To solve this issue, a new function was added, making it so the errors from the log are written as std::cerr instead of calling EPROSIMA_LOG_ERROR.
@Mergifyio backport 3.1.x 3.0.x 2.14.x
Fixes #5524
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist