-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22616] Easy Mode
enhancement and tutorial docs
#233
Conversation
When Fast DDS docs PR gets merged, need to replace a |
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
dcf22eb
to
dd62344
Compare
Signed-off-by: Mario Dominguez <[email protected]>
Auto Discovery Server Mode
enhancement and tutorial docsEasy Mode
enhancement and tutorial docs
When Fast DDS docs PR gets merged, need to replace a TODO with the corresponding link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job explaining the whole feature and illustrating it with all the figures!
Just some suggestions
Signed-off-by: Mario Dominguez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last three typos
Signed-off-by: Mario Dominguez <[email protected]>
b322249
to
fc77a4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
…ariable name Signed-off-by: Mario Dominguez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Mario Dominguez <[email protected]>
This PR adds the following documentation:
Auto Discovery Server Mode
in which the feature is explained.This PR must be merged after
New Vulcanexus Jazzy release