Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar #6

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Nav bar #6

merged 5 commits into from
Jun 20, 2024

Conversation

brunoLombardo
Copy link
Collaborator

header created

static targets = [ "arrow", "circle"]
static classes = [ "rotate", "hide"]

transform_add() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use camelCase for js variables and functions

Comment on lines +16 to +18
hide() {
this.circleTarget.classList.add(this.hideClass)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a different controller. One can be the "drop down controller" and other can be the "notification controller"

@JorgeLeites JorgeLeites merged commit 7ea57fd into main Jun 20, 2024
1 check passed
@JorgeLeites JorgeLeites deleted the nav_bar branch June 20, 2024 13:37
@JorgeLeites JorgeLeites mentioned this pull request Jun 20, 2024
@JorgeLeites JorgeLeites restored the nav_bar branch June 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants