Setting a logger without its level

This may not have an real use-case, but Firecracker supports the combination. Signed-off-by: Kazuyoshi Kato <[email protected]>
ease-lab · Sep 2, 2020 · 758a422 · 758a422
1 parent ee1e7c4
commit 758a422
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/machine.go b/machine.go
@@ -616,9 +616,16 @@ func (m *Machine) setupLogging(ctx context.Context) error {
 		return nil
 	}
 
+	// m.Cfg.LogLevel cannot be nil, but Firecracker allows setting a logger
+	// without its level. Converting "" to nil to support the corner case.
+	level := String(m.Cfg.LogLevel)
+	if StringValue(level) == "" {
+		level = nil
+	}
+
 	l := models.Logger{
 		LogPath:       String(path),
-		Level:         String(m.Cfg.LogLevel),
+		Level:         level,
 		ShowLevel:     Bool(true),
 		ShowLogOrigin: Bool(false),
 	}

diff --git a/machine_test.go b/machine_test.go
@@ -424,6 +424,7 @@ func TestLogAndMetrics(t *testing.T) {
 		logLevel string
 		quiet    bool
 	}{
+		{logLevel: "", quiet: false},
 		{logLevel: "Info", quiet: false},
 		{logLevel: "Error", quiet: true},
 	}
@@ -432,9 +433,15 @@ func TestLogAndMetrics(t *testing.T) {
 			out := testLogAndMetrics(t, test.logLevel)
 			if test.quiet {
 				assert.Regexp(t, `^Running Firecracker v0\.\d+\.0`, out)
-			} else {
-				assert.Contains(t, string(out), ":"+strings.ToUpper(test.logLevel)+"]")
+				return
 			}
+
+			// By default, Firecracker's log level is Warn.
+			logLevel := "WARN"
+			if test.logLevel != "" {
+				logLevel = strings.ToUpper(test.logLevel)
+			}
+			assert.Contains(t, out, ":"+logLevel+"]")
 		})
 	}
 }