Bugfix update due to spec changes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in this commit update the handling of the IPFS gateway environment variable. Previously, the remote gateway URLs were appended to the existing value of the `IPFS_GATEWAY` environment variable. Now, the code checks if the variable already exists and appends the local gateway URL with the specified gateway port. If the variable doesn't exist, it creates a new one with the local gateway URL. This change is in accordance with modifications to spec IPIP-280
Revised handling of adding env variables. Note `gateway.pinata.cloud` has been removed. See this issue for more details fsspec/ipfsspec#17 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address #25 with updates to the ipfs spec