Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): app-wall dependencies #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(): app-wall dependencies #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bricks/data-view/src/app-wall/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface AppWallProps {
*/
@defineElement("data-view.app-wall", {
styleTexts: [variablesStyleText, styleText],
dependencies: ["data-view.app-wall-card-item", "data-view.app-wall-relation-line", "data-view.app-wall-system-card"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有自动扫描到吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为这里用的是原生 three.js ，所以子构件没有用 wrapBrick 而是用 document.createElement 的方式来创建的，就没有自动扫描进依赖里了。

})
class AppWall
extends ReactNextElement
Expand Down
3 changes: 0 additions & 3 deletions bricks/data-view/src/app-wall/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import { MathUtils, EllipseCurve, LineCurve, Vector2, Vector3, Object3D, Quaternion, Euler,Vector3Tuple } from "three";
import { CSS3DObject } from 'three/addons/renderers/CSS3DRenderer.js';
import "./card-item/index.js";
import "./relation-line/index.js";
import "./system-card/index.js";
import type { AppWallCardItem, AppWallCardItemProps } from "./card-item/index.js";
import type { AppWallRelationLine, AppWallRelationLineProps } from "./relation-line/index.js";
import type { SystemCard, SystemCardProps } from "./system-card/index.js";
Expand Down