Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new rope(x, complement = TRUE) #699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

new rope(x, complement = TRUE) #699

wants to merge 1 commit into from

Conversation

mattansb
Copy link
Member

@mattansb mattansb commented Feb 13, 2025

New feature to report posterior probabilities above/below the rope for a more full picture.

library(bayestestR)

x <- rnorm(4000, sd = 5)

rope(x, complement = TRUE)
#> # Proportion of samples inside the ROPE [-0.10, 0.10]:
#> 
#> Inside ROPE | Above ROPE | Below ROPE
#> -------------------------------------
#> 1.61 %      |    49.08 % |    49.32 %
  • add tests

@DominiqueMakowski
Copy link
Member

I'd make that default rather than a toggleable option

@mattansb
Copy link
Member Author

Yeah? I thought of this as supplementary...

@DominiqueMakowski
Copy link
Member

I think it's pretty useful, and it's not a breaking change of the return format since we already return a dataframe so 🤷

If we make it optional it will likely end up in the abyss of forgotten features ^^

@mattansb
Copy link
Member Author

Fair enough. Then should this even be optional? Should complement = FALSE be an option at all?

@DominiqueMakowski
Copy link
Member

I'd say no :p
Let's just document in the docstrings what are these columns and how to interpret them / how useful they can be

@strengejacke
Copy link
Member

Have you checked if this breaks any other packages? (parameters::model_parameetrs() for Bayesian?)

@strengejacke
Copy link
Member

Agree to include it in general and have no option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants