-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN submission #284
Conversation
Let's merge this one before releasing: |
Yes, I just wanted to open a PR for this. I think you must submit, anyway. |
@IndrajeetPatil I don't understand what these failed tests mean. Could you help me resolve? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 64.82% 64.90% +0.07%
==========================================
Files 43 43
Lines 1760 1758 -2
==========================================
Hits 1141 1141
+ Misses 619 617 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I've got fixes for the warnings in the examples and vignettes. I'm not following why there are errors in oldrel-2 and oldrel-3. The errors don't make sense to me why they would occur there. @IndrajeetPatil any insights? |
I am not sure either why the snapshots don't match for these versions. I had created an issue to track this: #281 But, this should not get in the way of the CRAN release, since CRAN doesn't test packages on oldrel-2 or prior releases. |
Why didn't you submit the build from this branch before merging? |
Oh, the workflow I have used is to merge and then submit from main |
Fixes #283