Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CRAN submission #284

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Prepare CRAN submission #284

merged 8 commits into from
Apr 5, 2023

Conversation

strengejacke
Copy link
Member

Fixes #283

@bwiernik
Copy link
Contributor

bwiernik commented Apr 5, 2023

Let's merge this one before releasing:

#285

@strengejacke
Copy link
Member Author

Yes, I just wanted to open a PR for this. I think you must submit, anyway.

@bwiernik
Copy link
Contributor

bwiernik commented Apr 5, 2023

@IndrajeetPatil I don't understand what these failed tests mean. Could you help me resolve?

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #284 (15891b7) into main (31b031f) will increase coverage by 0.07%.
The diff coverage is 56.94%.

❗ Current head 15891b7 differs from pull request most recent head e7dcc57. Consider uploading reports for the commit e7dcc57 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   64.82%   64.90%   +0.07%     
==========================================
  Files          43       43              
  Lines        1760     1758       -2     
==========================================
  Hits         1141     1141              
+ Misses        619      617       -2     
Impacted Files Coverage Δ
R/cor_test_biserial.R 88.63% <0.00%> (+1.96%) ⬆️
R/cor_test_distance.R 58.02% <0.00%> (ø)
R/cor_test_tetrachoric.R 95.23% <0.00%> (ø)
R/cor_text.R 0.00% <0.00%> (ø)
R/cor_to_spcor.R 77.77% <0.00%> (ø)
R/utils_create_diagonal.R 71.42% <0.00%> (+3.86%) ⬆️
R/visualisation_recipe.cor_test.R 0.00% <0.00%> (ø)
R/visualisation_recipe.easycormatrix.R 0.00% <0.00%> (ø)
R/correlation.R 95.30% <50.00%> (-0.49%) ⬇️
R/cor_to_cov.R 83.33% <60.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwiernik
Copy link
Contributor

bwiernik commented Apr 5, 2023

I've got fixes for the warnings in the examples and vignettes. I'm not following why there are errors in oldrel-2 and oldrel-3. The errors don't make sense to me why they would occur there. @IndrajeetPatil any insights?

@IndrajeetPatil
Copy link
Member

I've got fixes for the warnings in the examples and vignettes. I'm not following why there are errors in oldrel-2 and oldrel-3. The errors don't make sense to me why they would occur there. @IndrajeetPatil any insights?

I am not sure either why the snapshots don't match for these versions. I had created an issue to track this: #281

But, this should not get in the way of the CRAN release, since CRAN doesn't test packages on oldrel-2 or prior releases.

@bwiernik bwiernik merged commit ce57718 into main Apr 5, 2023
@bwiernik bwiernik deleted the rc_0_8_4 branch April 5, 2023 21:59
@strengejacke
Copy link
Member Author

Why didn't you submit the build from this branch before merging?

@bwiernik
Copy link
Contributor

bwiernik commented Apr 6, 2023

Oh, the workflow I have used is to merge and then submit from main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN check failures
4 participants