Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datawizard version of unite() #424

Merged
merged 13 commits into from
May 26, 2023
Merged

datawizard version of unite() #424

merged 13 commits into from
May 26, 2023

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented May 25, 2023

Partly addresses #423

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #424 (8816a9d) into main (74c0cb9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 8816a9d differs from pull request most recent head 9d3e728. Consider uploading reports for the commit 9d3e728 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   87.94%   88.03%   +0.08%     
==========================================
  Files          65       66       +1     
  Lines        4755     4787      +32     
==========================================
+ Hits         4182     4214      +32     
  Misses        573      573              
Impacted Files Coverage Δ
R/data_unite.R 100.00% <100.00%> (ø)

R/data_unite.R Show resolved Hide resolved
R/data_unite.R Show resolved Hide resolved
R/data_unite.R Show resolved Hide resolved
R/data_unite.R Outdated Show resolved Hide resolved
R/data_unite.R Show resolved Hide resolved
R/data_unite.R Outdated Show resolved Hide resolved
Copy link
Member

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly on the argument append.

Otherwise once the description and news are updated I think this is good to go (except if you want to add the separate() version as well?)

R/data_unite.R Outdated Show resolved Hide resolved
R/data_unite.R Outdated Show resolved Hide resolved
R/data_unite.R Show resolved Hide resolved
strengejacke and others added 2 commits May 26, 2023 13:48
Co-authored-by: Etienne Bacher <[email protected]>
Co-authored-by: Etienne Bacher <[email protected]>
@strengejacke
Copy link
Member Author

(except if you want to add the separate() version as well?)

Maybe in a separate PR.

@etiennebacher etiennebacher changed the title datawizard versions of separate() and unite() datawizard version of unite() May 26, 2023
@strengejacke strengejacke merged commit 49a4ea1 into main May 26, 2023
@strengejacke strengejacke deleted the strengejacke/issue423 branch May 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants