-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datawizard version of unite()
#424
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 87.94% 88.03% +0.08%
==========================================
Files 65 66 +1
Lines 4755 4787 +32
==========================================
+ Hits 4182 4214 +32
Misses 573 573
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, mostly on the argument append
.
Otherwise once the description and news are updated I think this is good to go (except if you want to add the separate()
version as well?)
Co-authored-by: Etienne Bacher <[email protected]>
Co-authored-by: Etienne Bacher <[email protected]>
Maybe in a separate PR. |
unite()
Partly addresses #423