-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data_summary()
works with bayestestR::ci()
#483
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 90.66% 90.60% -0.06%
==========================================
Files 74 74
Lines 5765 5771 +6
==========================================
+ Hits 5227 5229 +2
- Misses 538 542 +4 ☔ View full report in Codecov by Sentry. |
@easystats/core-team Do we want to merge this? @DominiqueMakowski ? |
I have no strong opinion either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to wait for other feedback from the team but this is fine for me, I just have a couple of minor comments.
Haha, meanwhile we have added this code: # check for correct length of output - must be a single value!
if (any(lengths(out) != 1)) {
insight::format_error(
paste0(
"Each expression must return a single value. Following expression",
ifelse(sum(lengths(out) != 1) > 1, "s", " "),
" returned more than one value: ",
text_concatenate(vapply(dots[lengths(out) != 1], insight::safe_deparse, character(1)), enclose = "\"")
)
)
} and this PR doesn't work anymore. Let me try to fix this. |
Created on 2024-03-03 with reprex v2.1.0