Add methode to define an offset on OrderId #208
Conversation
Add possibility to set an offset on orderId from EbicsClient Object.
benjamin-si
changed the title
| * | ||
| * @return string | ||
| */ | ||
| public function generateOrderId(string $partnerId): string | ||
| public function generateOrderId(string $partnerId, int $offset = 0): string |
There was a problem hiding this comment.
I believe it will be Okay just to change logic for generateOrderId without option to impact on algo by pass offset.
There was a problem hiding this comment.
@andrew-svirin I'm not sure I understand, the idea would be to pass another value than the partner ID?
There was a problem hiding this comment.
I mean just change previous logic to a new one. If it works with your bank and If tests will pass, then it will single correct variant for generation OrderId and no need to adopt different algorithms for different banks.
There was a problem hiding this comment.
I see, but the purpose is to be able to change this number. The banks block the orderId in case of failure on a call INI for example. It's seem to be a general case.
To make another you have to change this orderID. I don't see how I could change the logic of the orderId without passing an offset.
There was a problem hiding this comment.
@benjamin-si would it work if you make default logic with offset?
There was a problem hiding this comment.
or maybe just manual define a orderId, it will be easier
There was a problem hiding this comment.
Maybe add to algorith dependency on current time? To be sure that next time it will generate a new value?
There was a problem hiding this comment.
Yes, but you need the same orderId on an INI and HIA call. If it is made separately, it could generate two different orderId.
There was a problem hiding this comment.
Hm, As I remember INI and HIA does not require to have he same orderId. But I will check it in specification.
There was a problem hiding this comment.
I found only this information. Take in account that if you abort transaction without acknowladge, then this orderId can be hanged for some time.
Add possibility to set an offset on orderId from EbicsClient Object.
To be used for certain banks that require the orderId to be incremented to get around an erroneous initialization call.