Safari compatibility (project file and basic demo) #41
Conversation
vheun
commented
Sep 16, 2016
•
vheun
commented
- led and const are not supported by safari, for compatibility among all browsers they are replaced with var.
- Safari seems to handle the asynchronous loading process different then chrome and firefox. getAllEntries() needs to be called within onwriteend(), otherwise it produces an empty entry when a file is uploaded in Safari.
# led and const are not supported by safari, they are replaced with var # Safari seems to handle the asynchronous file loading process different then chrome and firefox. getAllEntries() needs to be called within onwriteend(), otherwise it produces an empty entry when a file is uploaded.
| @@ -70,7 +71,10 @@ const support = function() { | |||
| }; | |||
| }; | |||
|
|
|||
| const Base64ToBlob = function(dataURL) { | |||
| // this is called to set IDB_SUPPORTS_BLOB at all times | |||
| support(); | |||
There was a problem hiding this comment.
The was my bad. Let's rename the function to setSupportsBlob() and call it here.
| exports.msIndexedDB; | ||
| if (!indexedDB) { | ||
| return; | ||
| } | ||
|
|
||
| let IDB_SUPPORTS_BLOB = true; | ||
| var IDB_SUPPORTS_BLOB = false; |
There was a problem hiding this comment.
you shouldn't need to switch over the const/lets. The src goes through closure which produces ES5. Please revert those changes.
There was a problem hiding this comment.
I love led and const, but it seems to not make a difference in this project and some people (like me) like to use the not minified files in the project development process, which then would produce an error.
There was a problem hiding this comment.
Most modern browsers support let/const out of the box and it's only a matter of time before Safari 10 supports both. I'd also like to move to full es6 support eventually so it's more important that the untransformed source be easier to maintain.
There was a problem hiding this comment.
But isn't the idea of this work to make filesystem API accessible for (older) browsers that do not support filesystem API? Chrome has it and firefox starts to support it. Its Safari that profits most. The advantages available for led and const are not that big to make a file incompatible with the purpose it should surf. I don't want to be rude. Its an amazing project. I understand the wish to run with the latest standards and I would love to use let in all my projects as well cause it would save me from a lot of overhead, but I kind of disagree with the choice in this case.
There was a problem hiding this comment.
The transpired file that's in dist/ works in all browsers. Put it this way, if this source was written in .ts or .coffee, it would require transpilation to run in older browsers. The same is currently true for es6 features. Ultimately, it doesn't matter how the source is written because we're now providing a built file.
|
This likely fixes the issue i just reported? #46 |
|
@clopez As you pointed out, the demo in master (http://rawgit.com/ebidel/idb.filesystem.js/master/demos/basic/) already works in Safari. It's html5-demos.appspot.com that needs to be updated. |
