Add ability score increases for 5e feats #641
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebullient
approved these changes
Feb 13, 2025
|
|
||
| static AbilityScoreIncreaseFields abilityScoreIncreaseFieldFromString(String name) { | ||
| for (AbilityScoreIncreaseFields field : AbilityScoreIncreaseFields.values()) { | ||
| if (field.name().equals(name)) |
There was a problem hiding this comment.
It was to allow me to handle int with a special case since in 5eTools the string is "int" but that's reserved so I can't make that the key name in the enum. I can probably do it another way as well. This was just how I thought it up at the time.
…e improvements for 5e feats
…rsing, cleaned up code
xhudaman
force-pushed
the
5e-feat-ability
branch
from
7ee3b32 to
c07984f
Compare
|
Not too sure about the testing to be honest. I could use some guidance on that. Off the top of my head just testing different variants of the data shape and that an increase for int gets parsed and mapped to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability score increase to 5e feats.
Issue: #290