Skip to content

Commit

Permalink
Re-enable select tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jayvarner committed Sep 25, 2023
1 parent 75cf30b commit a9330f7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion apps/export/export.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# zip file of base jekyll site with digital edition templates
JEKYLL_THEME_ZIP = digitaledition_jekylltheme.ZIPFILE_PATH

# The GitHub action env does not seem to find the zip file.
# FIXME: The GitHub action env does not seem to find the zip file.
if os.environ['DJANGO_ENV'] == 'test' and not os.path.exists(JEKYLL_THEME_ZIP):
JEKYLL_THEME_ZIP = os.path.join(settings.APPS_DIR, 'export', 'tests', 'fixtures', 'digitaledition-jekylltheme.zip')

Expand Down
24 changes: 12 additions & 12 deletions apps/readux/tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -423,12 +423,12 @@ def test_volume_list_view_no_kwargs(self):
assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
assert context['object_list'].count() == Manifest.objects.all().count()

# def test_volume_list_invalid_kwargs(self):
# kwargs = {'blueberry': 'pizza', 'jay': 'awesome'}
# response = self.client.get(reverse('volumes list'), data=kwargs)
# context = response.context_data
# assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
# assert context['object_list'].count() == Manifest.objects.all().count()
def test_volume_list_invalid_kwargs(self):
kwargs = {'blueberry': 'pizza', 'jay': 'awesome'}
response = self.client.get(reverse('volumes list'), data=kwargs)
context = response.context_data
assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
assert context['object_list'].count() == Manifest.objects.all().count()

def test_volumes_list_view_sort_and_order(self):
view = VolumesList()
Expand All @@ -448,12 +448,12 @@ def test_collection_detail_view_no_kwargs(self):
assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
assert context['object_list'].count() == Manifest.objects.all().count()

# def test_collection_detail_invalid_kwargs(self):
# kwargs = {'blueberry': 'pizza', 'jay': 'awesome'}
# response = self.client.get(reverse('volumes list'), data=kwargs)
# context = response.context_data
# assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
# assert context['object_list'].count() == Manifest.objects.all().count()
def test_collection_detail_invalid_kwargs(self):
kwargs = {'blueberry': 'pizza', 'jay': 'awesome'}
response = self.client.get(reverse('volumes list'), data=kwargs)
context = response.context_data
assert context['order_url_params'] == urlencode({'sort': 'title', 'order': 'asc'})
assert context['object_list'].count() == Manifest.objects.all().count()

# TODO are the volumes actually sorted?
def test_collection_detail_view_sort_and_order(self):
Expand Down

0 comments on commit a9330f7

Please sign in to comment.