Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mb/theme container #2715

Merged
merged 8 commits into from
Jul 11, 2023
Merged

Mb/theme container #2715

merged 8 commits into from
Jul 11, 2023

Conversation

moazzambukhari
Copy link
Contributor

@moazzambukhari moazzambukhari commented Jul 10, 2023 •
edited by noumantahir
Loading

What does this PR?

Theme Container Migration

Tested and Verified?

  • wallet view
  • editor container
  • snippet editor
  • applicationContainer
  • boostPlaceHolderView
  • CommentPlaceHolder
  • PostCardPlaceHolder
  • ListItemPlaceHolderView
  • PostPlaceHolderView
  • ProfileSummaryPlaceHolder
  • WalletDetailsPlaceHolder
  • TitleAreaView
  • HeaderContainer
  • postsListContainer
  • SnippetEditorModal
  • WalletView
    on testing the app

Steps to reproduce

Issue number

#2712

Screenshots/Video

noumantahir
noumantahir requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try to test each changed file to make sure every migration went smoothly... if you are unable to access some changed part in app feel free to ask on how to access..

Although most of changes seems to be working but still we must be certain
Screenshot 2023-07-11 003251

noumantahir
noumantahir approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now...

@feruzm feruzm merged commit d7d29fa into development Jul 11, 2023
@feruzm feruzm deleted the mb/theme-container branch July 11, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noumantahir noumantahir noumantahir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moazzambukhari @noumantahir @feruzm