Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widevane #185

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Widevane #185

merged 2 commits into from
Nov 27, 2024

Conversation

arnerek
Copy link
Contributor

@arnerek arnerek commented Nov 22, 2024

I updated the code to be similar as the SwiCago Heatpump reading of the wide vane. This works for my heat-pump.

It seems that this setting has been subject to multiple attempts, so I don’t know whether this change will break functionality for some pumps.

Solves #152 for me

@echavet
Copy link
Owner

echavet commented Nov 27, 2024

Hello @arnerek
thanks for your pull request, and sorry for late response.
ok the if (this->wideVaneAdj) { was a mistake. Good job.
Thanks for your work..

@echavet echavet merged commit bc1c88e into echavet:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants