-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish updates only on changes #210
Conversation
Thanks for your work |
I think I remember why I ended up putting The connection to the module was systematically lost after a while. |
For the second commit |
I've had it running like this for about 24 hours and everything looks good. I tried turning on the unit with the remote control and the ESP received the right settings. Looking good! These changes don't affect the cycle communication with the unit as far as I can tell. |
Not sure if this is related however I recompiled my install to see if it would fix my fan mode errors and now my esp32 crashes after startup. Is there a way I can install a prior version to see if it fixes the issue? |
I had the same issue. |
I see the problem. I'll make a new PR with the fix. |
PR out with #213 should fix the typo |
figured out how to install this version in esphome and it works great. Thanks! |
There was already a check to only publish new status values when the status changed, but it had a bug: when comparing two
nan
values foroutsideAirTemperature
, the equality check would fail becausenan == nan
always fails in C++.There was also already a check to only publish new setting values when the settings changed, but the line wasn't included in the otherwise empty if block (maybe by mistake).
Stage, sub mode, and auto sub mode statuses needed new checks, since it appears they were excluded from the settings by commenting out
// this->heatpumpUpdate(receivedSettings)
and not including them in theheatpumpSettings
equality checks. Maybe this was a work in progress, or excluded later.Closes #206