Fix profile saving bug

The problem was that we called the onSave callback (which starts a coroutine to save the profile) and didn't wait for it to finish before navigating to the map.
echo-swent · Jun 2, 2024 · dee5a0e · dee5a0e
1 parent fe793f9
commit dee5a0e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt b/app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt
@@ -160,7 +160,7 @@ fun ProfileCreationScreen(
         onFirstNameChange = viewModel::setFirstName,
         onLastNameChange = viewModel::setLastName,
         isEditing = isEditing,
-        isOnline = isOnline && state != CreateProfileState.SAVING,
+        isOnline = isOnline && state == CreateProfileState.EDIT,
         picture = picture,
         onPictureChange = viewModel::setPicture
     )
@@ -176,7 +176,7 @@ fun ProfileCreationScreen(
         )
     }
 
-    if (state == CreateProfileState.SAVING) {
+    if (state != CreateProfileState.EDIT) {
         Box(
             modifier =
                 Modifier.fillMaxSize()
@@ -369,7 +369,6 @@ fun ProfileCreationUI(
                         } else {
                             try {
                                 onSave(firstName, lastName)
-                                navAction.navigateTo(Routes.MAP)
                             } catch (e: RepositoryStoreWhileNoInternetException) {
                                 scope.launch {
                                     snackbarHostState.showSnackbar(