Feature/adding association new attributes #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenade
requested changes
May 29, 2024
| stringResource(R.string.association_details_contact), | ||
| style = MaterialTheme.typography.titleSmall | ||
| ) | ||
| Spacer(modifier = Modifier.height(verticalSpace)) |
There was a problem hiding this comment.
This spacer is a bit too big in my opinion
app/src/main/res/values/strings.xml
Outdated
| @@ -130,5 +130,6 @@ | |||
| <string name="authentication_error_email_is_required">Email is required</string> | |||
| <string name="authentication_password_too_short">Password must be at least 8 characters</string> | |||
| <string name="authentication_error_passwords_do_not_match">Passwords do not match</string> | |||
| <string name="association_details_contact">Contact:</string> | |||
There was a problem hiding this comment.
you should add a space between contact and the column (Contact :)
ntissieres
force-pushed
the
feature/adding-association-new-attributes
branch
from
5921644 to
ad20ae0
Compare
ntissieres
force-pushed
the
feature/adding-association-new-attributes
branch
from
7a9bdfb to
86dd57f
Compare
Greenade
approved these changes
May 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporation of the new attributes in the UI :