Fix app crash when switching theme #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogradiste
force-pushed
the
fix/app-crash-when-switching-theme
branch
2 times, most recently
from
6af116d to
11a4f46
Compare
alejandrocalles
requested changes
May 31, 2024
There was a problem hiding this comment.
Amazing, thanks for fixing this! Good job on finding the source of the issue :)
I've made a small request for change, but other than that the code looks really clean.
One thing we could consider, in the future, is a way to only re-create the map on configuration changes, as it seems mildly inefficient to re-create the map every time we navigate to it (or every time we switch from list mode to map mode).
However, for the moment, the app seems to be running as smoothly as before, so it may not even be an issue.
app/src/main/java/com/github/swent/echo/compose/map/MapLibreMapViewProvider.kt
Outdated
Show resolved
Hide resolved
The problem was that we kept the same instance of the `mapView` across configuration changes. Therefore, when switching the theme, the `mapView` already had a parent view which causes an `IllegalStateException`. To fix this, I recreate the `mapView` at every configuration change. This has the side effect of re-centering the map at every configuration change. To avoid this, I save the camera position every time it moves, so I can restore the previous camera position when the map is recreated.
octogradiste
force-pushed
the
fix/app-crash-when-switching-theme
branch
from
11a4f46 to
44bd437
Compare
|
|
LGTM. Thanks :) |
alejandrocalles
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we kept the same instance of the
mapViewacross configuration changes. Therefore, when switching the theme, themapViewalready had a parent view which causes anIllegalStateException. To fix this, I recreate themapViewat every configuration change. This has the side effect of re-centering the map at every configuration change. To avoid this, I save the camera position every time it moves, so I can restore the previous camera position when the map is recreated. Closes #333.