Feature/filter by associations #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenade
force-pushed
the
feature/filter-by-associations
branch
from
268d62e to
27e3e31
Compare
srsingh04
previously approved these changes
May 30, 2024
| !_filtersContainer.value.classChecked || | ||
| _semester.value == "" || | ||
| event.tags.any { tag -> | ||
| tag.name.lowercase() == _semester.value.lowercase() | ||
| } | ||
| } | ||
| .filter { event -> | ||
| // filter by association | ||
| _selectedAssociation.value == -1 || |
There was a problem hiding this comment.
Knitpick: -1 can be defined as a private constant and then used here instead of directly using the value.
app/src/main/java/com/github/swent/echo/compose/components/searchmenu/SearchMenuFilters.kt
Show resolved
Hide resolved
| @@ -310,7 +332,8 @@ constructor( | |||
| * the default one, the search mode is on. | |||
| */ | |||
| private fun updateSearchMode() { | |||
| _searchMode.value = _filtersContainer.value != defaultFiltersContainer | |||
| _searchMode.value = | |||
| _filtersContainer.value != defaultFiltersContainer || _selectedAssociation.value != -1 | |||
There was a problem hiding this comment.
Again, the magic value -1 can be used in as a constant.
Greenade
force-pushed
the
feature/filter-by-associations
branch
from
6da05cf to
5ad9f78
Compare
|
srsingh04
reviewed
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it possible to filter by an association you follow through the dropdown menu in the search sheet