Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation for Repository, RemoteDataSource, .... #378

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

violoncelloCH
Copy link
Member

No description provided.

@violoncelloCH violoncelloCH added this to the Milestone 4 milestone May 31, 2024
@violoncelloCH violoncelloCH self-assigned this May 31, 2024
@violoncelloCH violoncelloCH force-pushed the jonas/documentation branch 3 times, most recently from 5a36c35 to 87c4648 Compare June 2, 2024 07:42
@violoncelloCH violoncelloCH marked this pull request as ready for review June 2, 2024 07:42
@unglazedstamp unglazedstamp self-requested a review June 2, 2024 11:59
Copy link

@unglazedstamp unglazedstamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for all these comments which make the code clearer. I just found some typo, see below.

Copy link

@unglazedstamp unglazedstamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violoncelloCH violoncelloCH force-pushed the jonas/documentation branch from e5ed97d to 3ef672c Compare June 2, 2024 15:09
@violoncelloCH violoncelloCH enabled auto-merge (rebase) June 2, 2024 15:09
@violoncelloCH violoncelloCH disabled auto-merge June 2, 2024 15:10
@violoncelloCH violoncelloCH force-pushed the jonas/documentation branch from 3ef672c to 557f902 Compare June 2, 2024 15:10
@violoncelloCH violoncelloCH enabled auto-merge (rebase) June 2, 2024 15:11
Copy link

sonarqubecloud bot commented Jun 2, 2024

@violoncelloCH violoncelloCH merged commit 3ee179e into main Jun 2, 2024
2 checks passed
@violoncelloCH violoncelloCH deleted the jonas/documentation branch June 2, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants