Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom config added as an optional argument #385

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

pseusys
Copy link
Contributor

@pseusys pseusys commented Jan 27, 2025

Honestly, it is really hard to use the library as it is as API (not as CLI) because of the global config object that .
I tried to address this issue (just like in my previous PR for Go that looks abandoned for almost a year now).

Do you have any plans about this library further development?
Of course I can use my own forks for now, but it would be a shame if all the features mentioned in our already rather old discussion would never be implemented.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e8de54) to head (5f3512e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          125       125           
=========================================
  Hits           125       125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kigawas
Copy link
Member

kigawas commented Jan 27, 2025

I'll merge this first and revamp the parameters later

@kigawas
Copy link
Member

kigawas commented Jan 27, 2025

Thanks for your pr

@kigawas kigawas merged commit dd209c7 into ecies:master Jan 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants