Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webhook for basyx wiki readthedocs integration #2

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

aaronzi
Copy link
Member

@aaronzi aaronzi commented Jan 12, 2024

I added a webhook to the BaSyx Wiki Repo to integrate readthedocs. I also had to enter a secret here which I of course can't enter in clear text. I'm unfamiliar with the workflow for creating repo-level secrets with otterdog. Please mail me ([email protected]) to get the secret for readthedocs to finalize the PR.

@aaronzi aaronzi requested review from a team as code owners January 12, 2024 09:43

This comment has been minimized.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2024

In order to share the webhook secret with us, you can follow the instructions at this page: https://gitlab.eclipse.org/eclipsefdn/security/scripts/-/wikis/Sharing-secrets-with-the-Eclipse-Foundation

Once we received the secret we will update this PR to reference it correctly.

Signed-off-by: Thomas Neidhart <[email protected]>

This comment has been minimized.

This comment has been minimized.

@aaronzi
Copy link
Member Author

aaronzi commented Jan 12, 2024

Thank you for your quick answer @netomi. I wrote to you on the chat service as described in the instruction page you sent.

Signed-off-by: Thomas Neidhart <[email protected]>
Copy link

Diff for cbf1869:
Printing local diff:

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-basyx[id=eclipse-basyx]
  there have been 5 validation infos, enable verbose output with '-v' to to display them.

+   add repo_webhook[url="https://readthedocs.org/api/v2/webhook/basyx-wiki/253837/", repository="basyx-wiki"] {
+     active                                                   = true
+     content_type                                             = "json"
+     events                                                   = [
+       "create"
+       "delete"
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://readthedocs.org/api/v2/webhook/basyx-wiki/253837/"
+   }
  
  Plan: 1 to add, 0 to change, 0 to delete.
Canonical Diff for cbf1869:
Showing canonical diff:

Organization eclipse-basyx[id=eclipse-basyx]

--- canonical
+++ original
@@ -277,8 +277,6 @@
       allow_update_branch: false
       default_branch: "master"
       delete_branch_on_merge: false
-      secret_scanning: "enabled"
-      secret_scanning_push_protection: "enabled"
       web_commit_signoff_required: false
       webhooks: [
         orgs.newRepoWebhook('https://readthedocs.org/api/v2/webhook/basyx-wiki/253837/') {

@netomi netomi merged commit 8897421 into eclipse-basyx:main Jan 12, 2024
2 checks passed
@netomi
Copy link
Contributor

netomi commented Jan 12, 2024

changes are live.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2024

delivery seems to be working:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants