-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Error when selecting an AAS that references a submodel not located in the Submodel Repository. #55
Comments
Hi @JS-Aibel, Thanks for reporting this. What would be the behavior you would prefer when clicking on an AAS that references a submodel that isn't there? Just show a warning? But you are absolutely right, an uncatched error that blocks the usage of the UI is not a good behaviour. |
Thanks for the reply, @aaronzi. It might be helpful with a warning that explains the different types of issues:
Pop-up warnings can be easily missed or forgotten. Therefore, it would be best if the warning is visible in the viewer whenever the AAS is selected. For example, the warning could be shown as a greyed-out submodel, displaying its ID and the reason for its absence. |
That's a great idea. I will add this to our backlog. We will definitely implement this! |
Fixed in #73 |
Describe the bug
An error occurs when selecting an AAS that references a submodel not located in the Submodel Repository.
To Reproduce
Steps to reproduce the behavior:
In the AAS Environment do as follows.
Expected behavior
According to the specification, the AssetAdministrationShell has a ‘soft’ reference to its Submodels, meaning it does not contain Submodels. Therefor, should the viewer account for missing submodels in the submodel Repository instead of triggering an error?
BaSyx (please complete the following information):
BaSyx configuration
Default from the Quick Start Guide.
The text was updated successfully, but these errors were encountered: