Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling not available submodel(-descriptor) #73

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented Oct 29, 2024

Description of Changes

Up till now not available submodel (from sm repo) resp. submodel-descritptors (from sm registry) led to an error, see #55

This PR tries to realisze some kind of ‘soft’ reference of submodels.

Case 1: submodel (via repo) available, submodel-descriptor (via registry) available

1_all_ok

Case 2: submodel (via repo) available, submodel-descriptor (via registry) NOT available

2_registry_nok___repo_ok

Case 3: submodel (via repo) NOT available, submodel-descriptor (via registry) available

3_registry_ok___repo_nok

Case 4: submodel (via repo) NOT available, submodel-descriptor (via registry) NOT available

4_registry_nok___repo_nok

Related Issue

Closes #55

@seicke seicke requested a review from aaronzi October 29, 2024 15:33
@seicke
Copy link
Member Author

seicke commented Oct 30, 2024

localhost_3999__aas=http___localhost_9981_shells_aHR0cHM6Ly9leGFtcGxlLmNvbS9zaGVsbHMvNDVmOTVyWUI path=http___localhost_9983_submodel-descriptors_aHR0cHM6Ly9leGFtcGxlLmNvbS9zaGVsbHMvNDVmOTVyWUIvc3

Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronzi aaronzi merged commit 7e93063 into eclipse-basyx:main Oct 31, 2024
2 checks passed
@seicke seicke deleted the seicke/issue55 branch November 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error when selecting an AAS that references a submodel not located in the Submodel Repository.
2 participants